Return job steps from slurmdb_jobs.get #167 #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovtorres
requested changes
Feb 18, 2020
There was a problem hiding this comment.
Hi @vkantchev . Thank you for this contribution! It looks great. Just a couple comments below. Also, would you be able to write a test for this change and or perhaps some screenshots of it working? Also, you'll need to rebase.
vkantchev
changed the title
# Resolved conflicts: # examples/listdb_jobs.py
giovtorres
reviewed
Feb 20, 2020
| JOBS_info[u'start'] = job.start | ||
| JOBS_info[u'state'] = job.state | ||
| JOBS_info[u'state_str'] = slurm.slurm_job_state_string(job.state) | ||
| JOBS_info[u'state_str'] = slurm.stringOrNone(slurm.slurm_job_state_string(job.state), '') |
There was a problem hiding this comment.
Does slurm_job_state_string ever return null?
There was a problem hiding this comment.
It returns byte array, e.g. b'123' which breaks things like json.dumps.
giovtorres
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.