Skip to content

Clean tnc_freq.txt #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2019
Merged

Clean tnc_freq.txt #216

merged 2 commits into from
May 5, 2019

Conversation

bact
Copy link
Member

@bact bact commented May 5, 2019 •
edited
Loading

  • Clean tnc_freq.txt, remove some numbers and non-sense sequence of characters, html escapes
  • tnc.word_freqs and ttc.word_freqs will now check split lines if it contains both word and frequency before trying to append
  • Change += to "".join() in udom83 soundex

@pep8speaks
Copy link

pep8speaks commented May 5, 2019 •
edited
Loading

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 59:80: E501 line too long (85 > 79 characters)

Comment last updated at 2019-05-05 09:29:00 UTC

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 87.324% when pulling 16cfbb1 on bact:dev into 277d4a4 on PyThaiNLP:dev.

@bact bact merged commit 6fc7c34 into PyThaiNLP:dev May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @pep8speaks @coveralls