-
Notifications
You must be signed in to change notification settings - Fork 285
Update benchmark-to-cli branch from dev branch #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update coverage test settings
Update from dev
Update check corpus version
Hello @wannaphong! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
#self.assertEqual( | ||
# thaiword_to_date("วันนี้").day + 1, | ||
# thaiword_to_date("พรุ่งนี้").day, | ||
#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we comment these lines out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we comment these lines out?
It has bug. (If date is 31 and tomorrow is 1, thaiword_to_date("วันนี้").day + 1
is 32)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, we will fix it later? should we create a issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can just skip the test. For example, we can do something similar to https://stackoverflow.com/a/16138561.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, we will fix it later? should we create a issue for that?
Yes.
fix test ci error.