Skip to content

Conversation

wannaphong
Copy link
Member

fix test ci error.

@wannaphong wannaphong requested a review from p16i June 9, 2020 13:23
@pep8speaks
Copy link

Hello @wannaphong! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 192:80: E501 line too long (91 > 79 characters)
Line 243:80: E501 line too long (82 > 79 characters)

Line 365:9: E265 block comment should start with '# '
Line 368:9: E265 block comment should start with '# '

@wannaphong wannaphong merged commit 90af32a into benchmark-to-cli Jun 12, 2020
#self.assertEqual(
# thaiword_to_date("วันนี้").day + 1,
# thaiword_to_date("พรุ่งนี้").day,
#)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we comment these lines out?

Copy link
Member Author

@wannaphong wannaphong Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we comment these lines out?

It has bug. (If date is 31 and tomorrow is 1, thaiword_to_date("วันนี้").day + 1 is 32)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, we will fix it later? should we create a issue for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can just skip the test. For example, we can do something similar to https://stackoverflow.com/a/16138561.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, we will fix it later? should we create a issue for that?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants