Skip to content

Conversation

Lumabots
Copy link

@Lumabots Lumabots commented Oct 6, 2025

Corrected type annotation for is_none_pred in test_find_util.py and adjusted import order for consistency in several test files. Added a pyright ignore comment in public.py to suppress a false positive type check. Minor regex fix in test_snowflake_datetime.py for ValueError match.

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Corrected type annotation for is_none_pred in test_find_util.py and adjusted import order for consistency in several test files. Added a pyright ignore comment in public.py to suppress a false positive type check. Minor regex fix in test_snowflake_datetime.py for ValueError match.
@Lumabots Lumabots requested a review from a team as a code owner October 6, 2025 13:23
@pycord-app
Copy link

pycord-app bot commented Oct 6, 2025

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/138/head:pr-138
git checkout pr-138

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord-next@refs/pull/138/head

Copy link

Documentation build overview

📚 pycord-next | 🛠️ Build #29835164 | 📁 Comparing 489f60d against latest (bc48553)


🔍 Preview build

Show files changed (1 files in total): 📝 1 modified | ➕ 0 added | ➖ 0 deleted
File Status
_modules/discord/utils/public.html 📝 modified

@Paillat-dev Paillat-dev changed the title Fix type annotations and import order in utils and tests fix: type annotations and import order in utils and tests Oct 6, 2025
@Paillat-dev Paillat-dev merged commit 93d095e into feat/tests Oct 6, 2025
24 of 25 checks passed
@Paillat-dev Paillat-dev deleted the ruff-+-based-pyright-fixed branch October 6, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants