Skip to content

Change custom_id MISSING comparison to None for Select class to match other components #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Change custom_id MISSING comparison to None for Select class to match other components #1060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions discord/ui/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class Select(Item[V]):
def __init__(
self,
*,
custom_id: str = MISSING,
custom_id: str = None,
placeholder: Optional[str] = None,
min_values: int = 1,
max_values: int = 1,
Expand All @@ -110,8 +110,8 @@ def __init__(
if not (isinstance(custom_id, str) or custom_id is None):
raise TypeError(f"expected custom_id to be str, not {custom_id.__class__.__name__}")

self._provided_custom_id = custom_id is not MISSING
custom_id = os.urandom(16).hex() if custom_id is MISSING else custom_id
self._provided_custom_id = custom_id is not None
custom_id = os.urandom(16).hex() if custom_id is None else custom_id
options = [] if options is MISSING else options
self._underlying = SelectMenu._raw_construct(
custom_id=custom_id,
Expand Down Expand Up @@ -297,7 +297,7 @@ def is_dispatchable(self) -> bool:
def select(
*,
placeholder: Optional[str] = None,
custom_id: str = MISSING,
custom_id: str = None,
min_values: int = 1,
max_values: int = 1,
options: List[SelectOption] = MISSING,
Expand Down