Skip to content

[WIP] Add reason kwarg for message deletion (for audit log support) #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 2, 2022
Merged

[WIP] Add reason kwarg for message deletion (for audit log support) #1067

merged 9 commits into from
Apr 2, 2022

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Feb 21, 2022 •
edited
Loading

Summary

This adds an optional reason kwarg to TextChannel.delete_messages, TextChannel.purge, and Message.delete, to support the X-Audit-Log-Reason header

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick self-assigned this Feb 21, 2022
@rtk-rnjn
Copy link
Contributor

Make reason keyword only argument

@krittick krittick mentioned this pull request Mar 4, 2022
Closed
3 tasks
BobDotCom
BobDotCom reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change reason to be keyword-only

BobDotCom
BobDotCom reviewed Mar 4, 2022
View reviewed changes
krittick and others added 4 commits April 1, 2022 15:58
@krittick
Merge branch 'Pycord-Development:master' into audit-log-reasons-delete
8e13684
@krittick @BobDotCom
Update discord/channel.py
371d0fc 
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@krittick @BobDotCom
Update discord/http.py
ae76af1 
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@krittick @BobDotCom
Update discord/channel.py
4acaee6 
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@krittick krittick marked this pull request as ready for review April 1, 2022 23:04
@krittick krittick added status: awaiting review Awaiting review from a maintainer and removed status: in progress Work in Progess labels Apr 1, 2022
@krittick krittick added this to the v2.0 milestone Apr 1, 2022
@krittick krittick enabled auto-merge (squash) April 1, 2022 23:05
@krittick
Copy link
Contributor Author

krittick commented Apr 1, 2022

This is ready for review.

@krittick krittick merged commit a8b5916 into Pycord-Development:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@Middledot Middledot Awaiting requested review from Middledot

Assignees

@krittick krittick

Labels
priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@krittick @rtk-rnjn @Lulalaby @Dorukyum @BobDotCom