Skip to content

Fix for InputText.value not being properly cleared for non-required fields #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Fix for InputText.value not being properly cleared for non-required fields #1094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions discord/ui/input_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def __init__(
required=required,
value=value,
)
self._input_value = None
self._input_value = False
self.row = row
self._rendered_row: Optional[int] = None

Expand Down Expand Up @@ -164,7 +164,10 @@ def required(self, value: Optional[bool]):
@property
def value(self) -> Optional[str]:
"""Optional[:class:`str`]: The value entered in the text field."""
return self._input_value or self._underlying.value
if self._input_value is not False:
# only False on init, otherwise the value was either set or cleared
return self._input_value # type: ignore
return self._underlying.value

@value.setter
def value(self, value: Optional[str]):
Expand Down