Skip to content

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Mar 4, 2022

Summary

This fixes persistent paginators that include the use of page groups (PageGroup), by allowing the custom_id parameter to be passed to PaginatorMenu when overriding Paginator.add_menu().

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: high High Priority bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. Merge normally ext.pages Relating to ext.pages labels Mar 4, 2022
@krittick krittick added this to the v2.0 milestone Mar 4, 2022
@krittick krittick self-assigned this Mar 4, 2022
@krittick krittick merged commit 9c37624 into Pycord-Development:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. ext.pages Relating to ext.pages priority: high High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant