Skip to content

Remove outdated note #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

Remove outdated note #1139

merged 1 commit into from
Mar 9, 2022

Conversation

Middledot
Copy link
Member

Summary

Embed attachments seem to support underscores.

image

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Middledot Middledot added the documentation Improvements or additions to documentation label Mar 9, 2022
@krittick krittick enabled auto-merge (squash) March 9, 2022 08:54
@krittick krittick merged commit 0469d13 into master Mar 9, 2022
@Middledot Middledot deleted the Middledot-patch-1 branch March 9, 2022 13:04
@Dorukyum Dorukyum mentioned this pull request Mar 9, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

+2 more reviewers

@krittick krittick krittick approved these changes

@ImNimboss ImNimboss ImNimboss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Middledot @krittick @Dorukyum @ImNimboss