Skip to content

Make id parameter positional only #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

Make id parameter positional only #114

merged 1 commit into from
Sep 16, 2021

Conversation

izxxr
Copy link
Contributor

@izxxr izxxr commented Sep 6, 2021 •
edited
Loading

Summary

Make id parameter positional only.

Being consistent with rest of the API and for a bit related reference, see this

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@BobDotCom BobDotCom self-requested a review September 9, 2021 15:00
@Middledot Middledot merged commit 1002a56 into Pycord-Development:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobDotCom BobDotCom BobDotCom approved these changes

+1 more reviewer

@CodeWithSwastik CodeWithSwastik CodeWithSwastik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izxxr @CodeWithSwastik @BobDotCom @Middledot