Skip to content

Add missing **kwargs to SlashCommandGroup #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2022
Merged

Add missing **kwargs to SlashCommandGroup #1151

merged 1 commit into from
Mar 10, 2022

Conversation

Dorukyum
Copy link
Member

Summary

Fixes #1150.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum added bug Something isn't working Merge with squash priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Mar 10, 2022
@Dorukyum Dorukyum self-assigned this Mar 10, 2022
@Dorukyum Dorukyum requested a review from krittick March 10, 2022 10:43
@ChickenDevs ChickenDevs enabled auto-merge (rebase) March 10, 2022 13:43
@Middledot
Copy link
Member

Does this work with the example code of #1127?

This was referenced Mar 10, 2022
Merged
Merged
@ChickenDevs ChickenDevs merged commit 8cd306e into master Mar 10, 2022
@Dorukyum Dorukyum deleted the groups-kwargs branch March 10, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobDotCom BobDotCom BobDotCom approved these changes

@krittick krittick Awaiting requested review from krittick

+1 more reviewer

@ChickenDevs ChickenDevs ChickenDevs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dorukyum Dorukyum

Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kwargs is not defined in SlashCommandGroup
4 participants
@Dorukyum @Middledot @ChickenDevs @BobDotCom