Skip to content

Fix typehints for send_modal methods #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2022
Merged

Fix typehints for send_modal methods #1157

merged 2 commits into from
Mar 12, 2022

Conversation

Dorukyum
Copy link
Member

Summary

These typehints seem to be incorrect.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum added bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Mar 10, 2022
@Dorukyum Dorukyum self-assigned this Mar 10, 2022
@krittick krittick enabled auto-merge (squash) March 10, 2022 20:37
@krittick krittick merged commit b5f6ad6 into Pycord-Development:master Mar 12, 2022
@Dorukyum Dorukyum deleted the send_modal-typehints branch January 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Middledot Middledot Middledot approved these changes

+1 more reviewer

@krittick krittick krittick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dorukyum Dorukyum

Labels
bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dorukyum @krittick @Middledot