Skip to content

Revert "Revert "Run parent checks in can_run"" #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Revert "Revert "Run parent checks in can_run"" #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion discord/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,10 @@ async def can_run(self, ctx: ApplicationContext) -> bool:
raise CheckFailure(f"The global check functions for command {self.name} failed.")

predicates = self.checks
if self.parent is not None:
# parent checks should be ran first
predicates = self.parent.checks + predicates

if not predicates:
# since we have no checks, then we just return True.
return True
Expand Down Expand Up @@ -898,7 +902,7 @@ def __init__(
self.subcommands: List[Union[SlashCommand, SlashCommandGroup]] = self.__initial_commands__
self.guild_ids = guild_ids
self.parent = parent
self.checks = []
self.checks = kwargs.get("checks", [])

self._before_invoke = None
self._after_invoke = None
Expand Down