Skip to content

Fix cog slash commands when using ctx.invoke() #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2022
Merged

Fix cog slash commands when using ctx.invoke() #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b1d458
Ensure command instances of all types are updated
DaTurr3t Mar 10, 2022
6c53ab2
Call application commands in cogs correctly
DaTurr3t Mar 10, 2022
22bfcd2
SlashCommandGroup has no callback, so exclude it
DaTurr3t Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion discord/cog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def __new__(cls: Type[CogMeta], *args: Any, **kwargs: Any) -> CogMeta:

# Update the Command instances dynamically as well
for command in new_cls.__cog_commands__:
if not isinstance(command, ApplicationCommand):
if not isinstance(command, SlashCommandGroup):
setattr(new_cls, command.callback.__name__, command)
parent = command.parent
if parent is not None:
Expand Down
2 changes: 2 additions & 0 deletions discord/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,8 @@ async def __call__(self, ctx, *args, **kwargs):
convert the arguments beforehand, so take care to pass the correct
arguments in.
"""
if self.cog is not None:
return await self.callback(self.cog, ctx, *args, **kwargs)
return await self.callback(ctx, *args, **kwargs)

@property
Expand Down