Skip to content

Conversation

krittick
Copy link
Contributor

Summary

This adds a new parameter menu_placeholder to the Paginator class, which allows users to specify the text shown in the PaginatorMenu instance used with page groups. Previously this required subclassing Paginator and overriding add_menu() to accomplish.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature Merge with squash ext.pages Relating to ext.pages labels Mar 11, 2022
@krittick krittick added this to the v2.0 milestone Mar 11, 2022
@krittick krittick self-assigned this Mar 11, 2022
@krittick krittick enabled auto-merge (squash) March 11, 2022 05:45
@krittick krittick merged commit a6a12ff into Pycord-Development:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext.pages Relating to ext.pages feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants