Skip to content

Inheritance issues #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2022
Merged

Inheritance issues #1192

merged 3 commits into from
Apr 2, 2022

Conversation

BobDotCom
Copy link
Contributor

Summary

Fixes a few issues with how classes inherit from each other, and improves typing for those objects. These changes should be solely internal and not affect usage.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom self-assigned this Mar 23, 2022
@Dorukyum
Copy link
Member

Is this pull request done?

@BobDotCom
Copy link
Contributor Author

Is this pull request done?
I was going to try to get a bit more done on it

@BobDotCom BobDotCom marked this pull request as draft March 24, 2022 03:29
@BobDotCom
Copy link
Contributor Author

Got busy, but this should be fine to merge as-is

@BobDotCom BobDotCom marked this pull request as ready for review March 26, 2022 17:21
@BobDotCom BobDotCom requested review from Dorukyum and krittick March 26, 2022 17:21
Dorukyum
Dorukyum approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@Dorukyum Dorukyum enabled auto-merge (squash) April 1, 2022 14:56
@Dorukyum Dorukyum merged commit d004382 into master Apr 2, 2022
@Lulalaby Lulalaby deleted the inheritance-issues branch June 9, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@krittick krittick Awaiting requested review from krittick

Assignees

@BobDotCom BobDotCom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobDotCom @Dorukyum @Lulalaby