Skip to content

Fix mypy error when type checking pycord with namespace_packages flag #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2022
Merged

Fix mypy error when type checking pycord with namespace_packages flag #1218

merged 1 commit into from
Apr 2, 2022

Conversation

Defelo
Copy link
Contributor

@Defelo Defelo commented Apr 1, 2022

Summary

Fixes #985

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom enabled auto-merge April 1, 2022 14:53
@Dorukyum Dorukyum mentioned this pull request Apr 1, 2022
Merged
7 tasks
@Lulalaby Lulalaby disabled auto-merge April 2, 2022 16:41
@Lulalaby Lulalaby merged commit 386e572 into Pycord-Development:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@BobDotCom BobDotCom BobDotCom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mypy can't type check pycord when namespace_packages are enabled
3 participants
@Defelo @Lulalaby @BobDotCom