Skip to content

Fix race condition in autocomplete #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2022
Merged

Fix race condition in autocomplete #1221

merged 1 commit into from
Apr 2, 2022

Conversation

BobDotCom
Copy link
Contributor

Summary

Fixes a race condition in autocomplete.
Closes #1190

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom self-assigned this Apr 1, 2022
@BobDotCom BobDotCom added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Apr 1, 2022
@BobDotCom BobDotCom enabled auto-merge April 1, 2022 22:18
@BobDotCom BobDotCom added this to the v2.0 milestone Apr 1, 2022
krittick
krittick approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@krittick krittick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BobDotCom BobDotCom merged commit 37c9567 into master Apr 2, 2022
@Dorukyum Dorukyum deleted the autocomplete-race-condition branch April 2, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

+1 more reviewer

@krittick krittick krittick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@BobDotCom BobDotCom

Labels
priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

autocomplete issues.
3 participants
@BobDotCom @krittick @Dorukyum