Skip to content

[ext.pages] Fix for "Unknown Message" errors when using ephemeral paginators #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2022
Merged

[ext.pages] Fix for "Unknown Message" errors when using ephemeral paginators #1224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a46f02
fix for "Unknown Message" errors when using an ephemeral paginator af…
krittick Apr 3, 2022
d5abc35
spelling error
krittick Apr 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions discord/ext/pages/pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,11 @@ async def respond(
ephemeral: :class:`bool`
Whether the paginator message and its components are ephemeral.
If ``target`` is specified, the ephemeral message content will be ``target_message`` instead.

.. warning::

If your paginator is ephemeral, it cannot have a timeout longer than 15 minutes (and cannot be persistent).

target: Optional[:class:`~discord.abc.Messageable`]
A target where the paginated message should be sent, if different from the original :class:`discord.Interaction`
target_message: :class:`str`
Expand All @@ -775,7 +780,7 @@ async def respond(
if target is not None and not isinstance(target, discord.abc.Messageable):
raise TypeError(f"expected abc.Messageable not {target.__class__!r}")

if ephemeral and self.timeout >= 900 or self.timeout is None:
if ephemeral and (self.timeout >= 900 or self.timeout is None):
raise ValueError(
"paginator responses cannot be ephemeral if the paginator timeout is 15 minutes or greater"
)
Expand All @@ -801,18 +806,17 @@ async def respond(
view=self,
ephemeral=ephemeral,
)
# convert from WebhookMessage to Message reference to bypass 15min webhook token timeout
msg = await msg.channel.fetch_message(msg.id)
# convert from WebhookMessage to Message reference to bypass 15min webhook token timeout (non-ephemeral messages only)
if not ephemeral:
msg = await msg.channel.fetch_message(msg.id)
else:
msg = await interaction.response.send_message(
content=page_content.content,
embeds=page_content.embeds,
view=self,
ephemeral=ephemeral,
)
if isinstance(msg, discord.WebhookMessage):
self.message = await msg.channel.fetch_message(msg.id)
elif isinstance(msg, discord.Message):
if isinstance(msg, (discord.Message, discord.WebhookMessage)):
self.message = msg
elif isinstance(msg, discord.Interaction):
self.message = await msg.original_message()
Expand Down