Add SlashCommand.guild_ids #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Middledot
reviewed
Aug 29, 2021
BobDotCom
requested changes
Aug 29, 2021
discord/commands.py
Outdated
| description = ( | ||
| kwargs.get("description") | ||
| or inspect.cleandoc(func.__doc__) | ||
| or "No description set" |
There was a problem hiding this comment.
We should raise an error if no description is given. it makes more sense as an extension of the API
discord/commands.py
Outdated
| options.pop(list(options)[0]) | ||
| for a, o in options: | ||
| if o.name == None: | ||
| if not o.name: |
There was a problem hiding this comment.
if o.name is None would be better if we are only checking for None
discord/commands.py
Outdated
| "name": self.name, | ||
| "description": self.description, | ||
| "options": [o.to_dict() for o in self.options], | ||
| "guild_ids": self.guild_ids, |
There was a problem hiding this comment.
We want guild_ids to be left out of this if guild_ids is None
BobDotCom
approved these changes
Aug 30, 2021
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Also refactored discord/commands.py
Checklist