-
-
Notifications
You must be signed in to change notification settings - Fork 481
feat: redo CV2 and New Modal implementation #2904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
changing this to a general feature pr teehee |
i = 0 | ||
for y in component.components: | ||
x = self.children[i] | ||
x.refresh_component(y) | ||
i += 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enumerate()
?
reference: Message | MessageReference | PartialMessage = ..., | ||
mention_author: bool = ..., | ||
view: View = ..., | ||
view: BaseView = ..., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No overloads for DesignerView and no content, embeds etc?
Same thing for all the other send methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i probably should but god it's a pain
Needs to update ext.pages too. |
Summary
View
andModal
now only support original components (Button
/Select
,InputText
) - assume behavior from <=2.6.1DesignerView
andDesignerModal
(names not finalised idk)DesignerView
andContainer
do not supportButton
,@button
,Select
and@select
directly; useActionRow
instead.Section
still supportsButton
as accessory and thebutton
decoratorDesignerModal
does not supportInputText
andSelect
directly; useLabel
instead.TextDisplay
still works as a top-level component.InputText.description
,Select.label
andSelect.description
are removed as they are part of theLabel
componentDesignerView
can still be used for v1 messages (supportingcontent
andembeds
) if you want to migrate toActionRow
for any reason.ActionRow
to aView
will add the row's children insteadItem
has been split intoViewItem
andModalItem
InputText
andLabel
now inheritModalItem
ViewItem
Select
andTextDisplay
inherit bothViewItem
andModalItem
(even thoughSelect
is not a top-level modal item, i believe it still fits)Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.