Skip to content

Code fixes #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

Code fixes #411

wants to merge 18 commits into from

Conversation

BobDotCom
Copy link
Contributor

Summary

A mass pull request that fixes as many bugs found by pylint as possible, in order to fix CI.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby added priority: high High Priority status: in progress Work in Progess labels Nov 7, 2021
Dorukyum
Dorukyum reviewed Nov 7, 2021
View reviewed changes
zeffo
zeffo reviewed Nov 7, 2021
View reviewed changes
@Lulalaby Lulalaby changed the base branch from master to core/typing November 10, 2021 19:17
@BobDotCom
Copy link
Contributor Author

?

@Lulalaby
Copy link
Member

I think we should merge all typing / lint prs into one and merge it after a big test into master.

@Lulalaby Lulalaby added this to the Pycord 2.0.0 milestone Nov 14, 2021
@BobDotCom BobDotCom modified the milestones: Pycord 2.0.0, Pycord 2.1.0 Nov 15, 2021
@BobDotCom
Copy link
Contributor Author

Bumped to 2.1 to prevent feature creep

@krittick krittick mentioned this pull request Dec 13, 2021
Closed
@Lulalaby Lulalaby deleted the branch Pycord-Development:core/typing January 27, 2022 04:23
@Lulalaby Lulalaby closed this Jan 27, 2022
@Lulalaby
Copy link
Member

Please re-do pr to master

@VincentRPS VincentRPS removed this from the v2.1 milestone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum left review comments

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@CodeWithSwastik CodeWithSwastik Awaiting requested review from CodeWithSwastik

@FrostByte266 FrostByte266 Awaiting requested review from FrostByte266

@Middledot Middledot Awaiting requested review from Middledot

+1 more reviewer

@zeffo zeffo zeffo left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Lulalaby Lulalaby

@FrostByte266 FrostByte266

@Dorukyum Dorukyum

@CodeWithSwastik CodeWithSwastik

@BobDotCom BobDotCom

@Middledot Middledot

Labels
priority: high High Priority status: in progress Work in Progess
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BobDotCom @Lulalaby @zeffo @Dorukyum @FrostByte266 @CodeWithSwastik @Middledot @VincentRPS