Skip to content

Conversation

ItsNeil17
Copy link

@ItsNeil17 ItsNeil17 commented Aug 31, 2021

Summary

This pull request changes wherever there is discord or discord.py in the docs and the main init.py file.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Seniatical
Copy link

This wasn't created by pycord. It's a fork of a project, which means they have no right to remove original copyright. As highlighted by Danny in my previous mistakes.
image

@ItsNeil17
Copy link
Author

Even though it was NOT voilating his copyright as I did not change it, I only changed where it said discord.py to pycord which is indeed allowed. I did not change his copyright, if you go and look there's still his copyright (2015-present copyright Rapptz) it clearly states Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software..

@ItsNeil17
Copy link
Author

I've changed it in the init file if you still think it's voilating.

@Seniatical
Copy link

The same goes with the docs, they can only claim it there's if:
A: They rewrite the build for sphinx
B: Use a different layout - Credits for the builder and extensions will still be required
C: Use something completely different like MKDocs

@Seniatical
Copy link

Seniatical commented Aug 31, 2021

And the __author__ and __title__ tag point to the original creator and project so yes it is changing the license to some extent

@namzop
Copy link

namzop commented Aug 31, 2021

He never removed the attribution from the license or the copyright
image
And maybe he sent you that message because you changed the attribution in the LICENSE file.

@namzop
Copy link

namzop commented Aug 31, 2021

I've changed it in the init file if you still think it's voilating.

As mentioned in the message, danny said that "he'd prefer if the license and copyright was kept without removing attribution" but you never removed attribution from the license or the copyright. You just changed the title from 'discord.py' to 'pycord' and the author's name. You never changed the license or copyright

@ItsNeil17 ItsNeil17 closed this Aug 31, 2021
@Seniatical
Copy link

He never removed the attribution from the license or the copyright
image
And maybe he sent you that message because you changed the attribution in the LICENSE file.

If you checked the commit it was the __init__

DA-344 pushed a commit to DA-344/pycord that referenced this pull request Oct 3, 2025
* Move utils.py to utils/

* 🔥 Remove `filter_params`

* ♻️ Merge `time_snowflake` and `generate_snowflake`, move `basic_autocomplete` to `utils/public.py`

* ♻️ Merge `time_snowflake` and `generate_snowflake`, move `basic_autocomplete` to `utils/public.py`

* 🔥 Remove `utils.sleep_until`

* chore: Start migration to uv & ruff & hatch (Pycord-Development#4)

* Start migration to uv

* Setup ruff and hatch

* Change pre-commit to use ruff

* Format with ruff

* Fix mistake

* Add dev deps

* Change workflows to use uv and ruff

* ➕ Add colorlog and remove requirements folder and fix build

* 💚 Fix sphinx build ?

* 🐛 Add __version.py for version management and update import in __init__.py

* ✏️ Update lib-checks.yml to run ruff on ubuntu-latest

* 🐛 Update lib-checks.yml to run mypy with uv

* 🔥 Delete MANIFEST.in

* ✨ Enhance lib-checks.yml to include ruff formatter check

* ♻️ Refactor pyproject.toml and uv.lock to use optional-dependencies for voice and speed

* Setup CHANGELOG.md (Pycord-Development#6)

* chore: update docs workflows to use 'uv' for dependency management (Pycord-Development#33)

* chore: Update localization workflows to use 'uv' for dependency management

* chore: refactor Read the Docs configuration to use uv

* 🔥 Move stuff to private

* :refactor: move parse_time function to private utils and update references

* 📝 update CHANGELOG to reflect utility function changes

* 🎨 Format

* ♻️ move deprecation utilities to private utils and update references

* ♻️ move snowflake_time function to public.py

* ♻️ move oauth_url and Undefined class to public.py; update imports

* 📝 remove deprecated utility functions from documentation

* 📝 remove (re)moved utility functions from documentation

* 📝 add utils.resolve_template to changelog and remove from documentation

* 🐛 fix import path for warn_deprecated utility function

* :refactor: reorganize utility function imports and move evaluate_annotation to private module

* ♻️ update import paths for utility functions to use relative imports

* ♻️ move delay_task function to private

* ♻️ removed `utils.get` in favor of `utils.find`

* ♻️ removed `utils._unique`

It was used twice, and once it wasn't even necessary

* ♻️ move `async_all` to private

* ♻️ move `maybe_coroutine` to private

* ♻️ rename `maybe_coroutine` to `maybe_awaitable`

* ♻️ move `sane_wait_for` to private

* ♻️ move `format_dt` to public

* ♻️ remove `as_chunks` function

* 📝 update `utils.sleep_until` and `utils.parse_time` changelog to suggest alternatives

* ♻️ move `compute_timedelta` function

* ♻️ move `valid_icon_size` to `asset.py`

* ♻️ refactor `utils.get` to `utils.find` across multiple files

* ♻️ refactor markdown and mention handling functions in `__init__.py` and `public.py`

* ♻️ move SnowflakeList to `private.py`

* ♻️ move `find` function from `__init__.py` to `public.py`

* ♻️ move `copy_doc` to private

* ♻️ refactor `get` to `find` in onboarding and sticker modules

* 🐛 fix `copy_doc` decorator usage in context.py

* ♻️ move SequenceProxy to private module

* ♻️ move cached_slot_property to private

* 🚨 add noqa comments to prevent linting errors

* ♻️ move get_slots function to private module

* ♻️ refactor JSON serialization functions to private module

* ♻️ replace custom cached_property implementation with functools.cached_property

* ✏️ fix typo in CHANGELOG-V3.md

* ➖ remove unused dependencies from pyproject.toml and uv.lock

* ⚰️ remove test.py

* ♻️ remove duplicate import of raw_mentions in __init__.py

* 🐛 fix raw_role_mentions import in utils/__init__.py

* 🔥 Duplicate `Iterable` import

* Apply suggestion from @Lumabots

Co-authored-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

* 🔥 Simplify imports

* 🔥 Simplify imports number 2

* 🔥 Simplify imports number 3 omg this is amazing

* 🔥 Simplify imports number 4 omg this is amazing yee

* 🔥 Simplify imports number 5

* Update discord/ext/commands/converter.py

Co-authored-by: Ice Wolfy <44532864+Icebluewolf@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

* Apply suggestions from code review

Co-authored-by: Ice Wolfy <44532864+Icebluewolf@users.noreply.github.com>
Co-authored-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

* Update discord/state.py

Co-authored-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

* Update discord/state.py

Co-authored-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

* ♻️ Remove _ prefix in from and to json

* ♻️ Make import less weird

* Update utils.po

Signed-off-by: Paillat <paillat@pycord.dev>

* empty commit

* Update discord/poll.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

* Update discord/utils/private.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>

* 🐛 Fix broken import after merge

* 🐛 Fix emojis.json path

* 🐛 Fix broken imports

* 🎨 Format stuff

* 🐛 Fix import

---------

Signed-off-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Paillat <paillat@pycord.dev>
Co-authored-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Co-authored-by: Ice Wolfy <44532864+Icebluewolf@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants