-
-
Notifications
You must be signed in to change notification settings - Fork 482
Add functions that set permissions for all slash commands in a cog #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not a bad idea but it would be inconsistent since |
So should I rework the PR around that? |
Thinking about it, the way I worded the title gives the wrong impression because none of the functions I added are actually decorators. So I guess I should just change the title of the PR |
Wait how did that dismiss the reviews |
By the way, how are these meant to be used? |
I intended for the functions to be used in cog_check, however I added 0 checks for that, so it could be used in the init function or any other function in the cog. |
How can these be used in the cog_check? That is a method ran as a check before every command of the cog while these methods set permissions for the commands. |
Okay, but do you know which function these cog decorators would go in? Plus, I have a better idea: each of the functions could still be ran in cog_check, however, it would just store an array of the permissions in the cog. Then later on, in another function, each of these permissions are loaded into every function. |
|
Could I redesign it around the perms in 2.1? |
No |
Okay. You can close it then if you'd like |
We discuss it internally |
Closing because of reworks with Command Permissions. |
Summary
This pull request implements #495 by having new functions that loop through each command and set the permissions
Checklist
type: ignore
comments were used, a comment is also left explaining why