Skip to content

Conversation

Ratery
Copy link
Contributor

@Ratery Ratery commented Jan 24, 2022

Summary

Fixed a bug when passing the option default value doesn't make it non-required.
For example:

@bot.slash_command()
async def command(ctx, opt: Option(int) = 123):
    ...
  • Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@VincentRPS VincentRPS added bug Something isn't working Merge normally priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Jan 26, 2022
@VincentRPS VincentRPS added this to the v2.0 milestone Jan 26, 2022
@Lulalaby Lulalaby merged commit 66887df into Pycord-Development:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants