Skip to content

Followup for #838 #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

Followup for #838 #888

merged 1 commit into from
Jan 31, 2022

Conversation

plun1331
Copy link
Member

Summary

Fixes usage of case insensitive commands, as they were being fetched from the incorrect property by the library.
Fixes #885

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@plun1331 plun1331 mentioned this pull request Jan 29, 2022
Closed
@Lulalaby Lulalaby enabled auto-merge (rebase) January 30, 2022 18:48
@Lulalaby Lulalaby added this to the v2.0 milestone Jan 30, 2022
@Lulalaby Lulalaby merged commit 68e9cf3 into Pycord-Development:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Middledot approved these changes

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

case_insensitive not working properly in 2.0.0b1
3 participants
@plun1331 @Lulalaby @Middledot