Skip to content

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Feb 9, 2022

Summary

This adds an example for adding an attachment as a slash command option type.

This also fixes the missing SlashCommandOptionType reference in __all__ in enums.py

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

also add missing SlashCommandOptionType to __all__ in enums.py
also add missing SlashCommandOptionType to __all__ in enums.py
@krittick krittick added status: awaiting review Awaiting review from a maintainer Merge with squash examples Pycord examples labels Feb 9, 2022
@krittick krittick added this to the v2.0 milestone Feb 9, 2022
@krittick krittick self-assigned this Feb 9, 2022
@krittick krittick enabled auto-merge (squash) February 9, 2022 01:58
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
Middledot
Middledot previously approved these changes Feb 9, 2022
@VincentRPS
Copy link
Contributor

@krittick why not just add this to the options example?

@krittick
Copy link
Contributor Author

krittick commented Feb 9, 2022

@krittick why not just add this to the options example?

Since you have to do some additional processing to make it work (e.g. to_file()), I felt that it's better as a standalone example.

@VincentRPS
Copy link
Contributor

@krittick why not just add this to the options example?

Since you have to do some additional processing to make it work (e.g. to_file()), I felt that it's better as a standalone example.

it's still a small enough example where it would be better there

@krittick
Copy link
Contributor Author

krittick commented Feb 9, 2022

@krittick why not just add this to the options example?

Since you have to do some additional processing to make it work (e.g. to_file()), I felt that it's better as a standalone example.

it's still a small enough example where it would be better there

Sure, I've updated it now.

BobDotCom
BobDotCom previously approved these changes Feb 9, 2022
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@krittick krittick merged commit a553809 into Pycord-Development:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Pycord examples status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants