Skip to content

Update Item references in modal.py to InputText #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2022
Merged

Update Item references in modal.py to InputText #966

merged 1 commit into from
Feb 9, 2022

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Feb 9, 2022

Summary

Updates Item references in modal.py to InputText to avoid confusion since only InputText is supported as a component type in modals right now.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick
update Item references in modal.py to InputText to avoid confusio…
0198f43 
…n as only `InputText` components are supported in modals right now
@krittick krittick added documentation Improvements or additions to documentation priority: low Low Priority status: awaiting review Awaiting review from a maintainer Merge normally labels Feb 9, 2022
@krittick krittick self-assigned this Feb 9, 2022
@BobDotCom BobDotCom enabled auto-merge February 9, 2022 21:40
@BobDotCom BobDotCom merged commit e133f84 into Pycord-Development:master Feb 9, 2022
@onerandomusername onerandomusername mentioned this pull request Feb 13, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobDotCom BobDotCom BobDotCom approved these changes

@Middledot Middledot Middledot approved these changes

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

@krittick krittick

Labels
documentation Improvements or additions to documentation priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krittick @BobDotCom @Middledot