Skip to content

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Feb 9, 2022

Summary

This removes the /examples/interactionsBot/ example from the repo.

Reasoning:

  1. It contains many fundamental problems, such as non-adherence to PEP8 standards with variable names (or even the folder name). There are also multiple duplicate comments, and some comments that simply contain the exact code in the line below it e.g.:
    `await ctx.respond(f"{round(self.client.latency * 1000)}ms",ephemeral=True)`
    """
    return await ctx.respond(f"{round(self.client.latency * 1000)}ms")
  2. All of its functionality is already well covered by other examples.
  3. The code quality in general is sub-par and not up to the standards shown in the other examples.
  4. Many of the references to the example in the discord server are related to errors, confusion, or other negative associations, causing unnecessary complexity and frustration for new bot developers.
  5. The commit history is not clear (squashed/force pushed?) and it makes it difficult to even see who created it, as it was merged from a trunk branch without showing that it's originally from Add More examples #484.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge normally examples Pycord examples labels Feb 9, 2022
@krittick krittick added this to the v2.0 milestone Feb 9, 2022
@krittick krittick self-assigned this Feb 9, 2022
@krittick krittick enabled auto-merge February 9, 2022 05:59
@krittick krittick merged commit 97b33db into Pycord-Development:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Pycord examples priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants