Make get_desynced_commands work with slash command groups
#986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobDotCom
previously approved these changes
Feb 10, 2022
EmmmaTech
previously approved these changes
Feb 10, 2022
|
Please resolve conflicts. Thanks! |
auto-merge was automatically disabled
February 12, 2022 15:04
Head branch was pushed to by a user without write access
|
Please run the pre-commit hooks for formatting, the lint action failed |
Ratery
force-pushed
the
fix-get-desynced-commands
branch
from
58a3df7 to
9f4bb9e
Compare
plun1331
reviewed
Feb 14, 2022
Ratery
changed the title
get_desynced_commands work for slash command groupsget_desynced_commands work with slash command groups
|
Please resolve conflicts. Thanks! |
krittick
added
Merge with squash
priority: medium
…/pycord into Ratery-fix-get-desynced-commands # Conflicts: # discord/bot.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
get_desynced_commandsfunction to be able to properly work with slash command groups.This PR implements recursive slash commands traversing to compare all nested subcommands.
Checklist
type: ignorecomments were used, a comment is also left explaining why