Skip to content

Move dev requirements to requirements-dev.txt #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2022
Merged

Move dev requirements to requirements-dev.txt #995

merged 2 commits into from
Feb 11, 2022

Conversation

BobDotCom
Copy link
Contributor

Summary

pre-commit was added to requirements.txt, but isn't required outside a development environment. This PR fixes that.

@BobDotCom BobDotCom added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer dependencies Pull requests that update a dependency file Merge normally labels Feb 11, 2022
@BobDotCom BobDotCom added this to the v2.0 milestone Feb 11, 2022
@BobDotCom BobDotCom requested a review from krittick February 11, 2022 16:21
@BobDotCom BobDotCom self-assigned this Feb 11, 2022
Dorukyum
Dorukyum approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check "this isn't a code change" instead of removing the checklist.

@Dorukyum Dorukyum enabled auto-merge February 11, 2022 16:33
@BobDotCom BobDotCom disabled auto-merge February 11, 2022 16:45
@BobDotCom BobDotCom enabled auto-merge (squash) February 11, 2022 16:45
krittick
krittick approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@krittick krittick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

@BobDotCom BobDotCom merged commit b183d19 into master Feb 11, 2022
@Lulalaby Lulalaby deleted the requirements-dev branch June 9, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

+1 more reviewer

@krittick krittick krittick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@BobDotCom BobDotCom

Labels
dependencies Pull requests that update a dependency file priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BobDotCom @krittick @Dorukyum