more complete template i18n support and german translation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add required i18n:domain and i18n:translate attributes to templates
- include newly marked translations strings from templates
|
I decided to remove the de translation and complete the de_DE translation instead. My reason for this decission was that colander has a de_DE translation and no de translation and it was easier to move my application's translation from de to de_DE too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider to pull my internationalization changes for deform.
I added i18n:domain and i18n:translate attributes in deform/templates/*.pt where they are required for proper internationalization. I updated the translation template file deform/locale/deform.pot and added a german translation in deform/locale/de. I did not change the existing german translation in deform/locale/de_DE because I needed the more generic Locale de. Maybe it would be a good idea to remove/merge the de_DE translation later.
Regards
Jan Dittberner