New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cookies on other domain when using parent_domain #1072

Merged
merged 1 commit into from Aug 15, 2013

Conversation

Projects
None yet
2 participants
@wichert
Member

wichert commented Aug 10, 2013

This address a comment from @enmand on Pylons/pyramid#1028: when using parent_domain you should never set a cookie on the current domain, or you risk getting invalid behaviour when logging in on one domain and doing logout on another domain.

@witsch

This comment has been minimized.

Show comment
Hide comment
@witsch

witsch Aug 15, 2013

Member

@tomster & i have pair-reviewed this and think it looks good, +2 on merging...

Member

witsch commented Aug 15, 2013

@tomster & i have pair-reviewed this and think it looks good, +2 on merging...

@witsch

This comment has been minimized.

Show comment
Hide comment
@witsch

witsch Aug 15, 2013

Member

merging after discussing the fix with @mcdonc...

Member

witsch commented Aug 15, 2013

merging after discussing the fix with @mcdonc...

witsch added a commit that referenced this pull request Aug 15, 2013

Merge pull request #1072 from wichert/auth-parent-domain-cleanup
No cookies on other domain when using parent_domain

@witsch witsch merged commit 9bde7c5 into Pylons:master Aug 15, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment