No cookies on other domain when using parent_domain #1072

Merged
merged 1 commit into from Aug 15, 2013

Projects

None yet

2 participants

@wichert
Pylons Project member

This address a comment from @enmand on Pylons/pyramid#1028: when using parent_domain you should never set a cookie on the current domain, or you risk getting invalid behaviour when logging in on one domain and doing logout on another domain.

@witsch
Pylons Project member

@tomster & i have pair-reviewed this and think it looks good, +2 on merging...

@witsch
Pylons Project member

merging after discussing the fix with @mcdonc...

@witsch witsch merged commit 9bde7c5 into Pylons:master Aug 15, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment