Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit auth cookie domain setting. #1078

merged 2 commits into from Aug 15, 2013


None yet
2 participants
Copy link

commented Aug 12, 2013

This builds on (and includes) the commit from #1072.

In some situations any standard rules for cookies do not apply and the only alternative is to hardcode the domain used for cookies. This pull request makes that possible by adding a new domain option to AuthTktAuthenticationPolicy.

wichert added some commits Aug 10, 2013

Allow explicit cookie domain setting.
This is useful as an escape hatch when dealing with enviroments where
no normal rules apply.

This comment has been minimized.

Copy link

commented Aug 15, 2013

this one also looks good (again being pair-reviewed by @tomster and me), tests pass and coverage is at 100%, +2 for merging...

witsch added a commit that referenced this pull request Aug 15, 2013

Merge pull request #1078 from wichert/auth-explicit-domain
Allow explicit auth cookie domain setting.

@witsch witsch merged commit 69e5c9e into Pylons:master Aug 15, 2013

1 check passed

default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.