Allow explicit auth cookie domain setting. #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful as an escape hatch when dealing with enviroments where no normal rules apply.
|
this one also looks good (again being pair-reviewed by @tomster and me), tests pass and coverage is at 100%, +2 for merging... |
witsch
added a commit
that referenced
this pull request
Aug 15, 2013
Allow explicit auth cookie domain setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on (and includes) the commit from #1072.
In some situations any standard rules for cookies do not apply and the only alternative is to hardcode the domain used for cookies. This pull request makes that possible by adding a new
domainoption to AuthTktAuthenticationPolicy.