- update HACKING.txt to show how to use pip instead of easy_install #2492
Conversation
stevepiercy
commented
Apr 13, 2016
stevepiercy
commented
- remove unnecessary tests stuff
- see Update HACKING.txt and Pyramid's setup.py to use pip #2474
- remove unnecessary tests stuff - see Pylons#2474
| 'docs': docs_extras, | ||
| }, | ||
| tests_require=tests_require, | ||
| test_suite="pyramid.tests", |
There was a problem hiding this comment.
Yeah you can't drop the test_suite and tests_require stuff here. The core isn't interested in dropping python setup.py test support just yet.
|
First draft. There are probably some things I cut that should not have been cut. Need feedback from core team. |
|
|
||
| $ cd ~/hack-on-pyramid | ||
| $ $VENV/bin/python setup.py dev | ||
| $ $VENV/bin/pip install -e . |
There was a problem hiding this comment.
You can just make this line $VENV/bin/pip install -e .[testing,docs] instead of adding multiple lines.
|
HACKING.txt update looks good. I would argue that instead of running tests directly using py.test, we teach people about I pretty much run: Whenever I make changes in Pyramid. This tests Python 2, and Python 3, and gives me a coverage report at the same time. It means I can keep iterating pretty quickly, and I get a nice overview of what is going on, and I don't have to worry that my local env is only Python 3.5 for example, and all tests pass, but I accidentally broke something on Py 2.7. |
mmerickel
changed the title
|
I'd like to get agreement on @bertjwregeer's suggestion before making any changes to HACKING.txt. |
|
|
||
| cd env27/hacking | ||
| ../bin/python setup.py develop | ||
| ../bin/pip install -e . | ||
| ../bin/pip install -e ".[testing,docs]" |
There was a problem hiding this comment.
Again, no need for both pip commands.
There was a problem hiding this comment.
Thanks, fixed in upcoming commit.
- fixed inconsistent command indents
|
👍 |
|
LGTM |
|
Closes #2474 |
