Waving hands game improvements #39
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpayne-ddm
approved these changes
Nov 11, 2022
trixtur
changed the title
handleEmptyBody
It would be interesting to actually check the response for this test.
The issue was that the test needed to be run in the go routine and the channel needed to be handled in the main rountine's test.
Started testing game dynamics.
…n of channels to do multi-communications.
This gesture does not interrupt a sequence.
Rounds were not being counted properly because the game was not passed by reference.
Includes a new spell to shield from damage causing spells like missile and non-spells like stab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be interesting to actually check the response for this test.