Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing more types of HDWallet derived Cardano addresses #103

Merged

Conversation

daehan-koreapool
Copy link
Contributor

Emurgo has Pointer and Enterprise address types included in their HDWallet derivation unit tests.
https://github.com/Emurgo/cardano-serialization-lib/blob/master/rust/src/address.rs

PyCardano should have these address types covered to build a stronger assurance for other developers to reliable utilize the HDWallet implementation.

@daehan-koreapool daehan-koreapool marked this pull request as draft October 19, 2022 06:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 86.00% // Head: 86.15% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (4a3dfbd) compared to base (af63f0f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   86.00%   86.15%   +0.15%     
==========================================
  Files          24       24              
  Lines        2630     2630              
  Branches      517      517              
==========================================
+ Hits         2262     2266       +4     
+ Misses        270      268       -2     
+ Partials       98       96       -2     
Impacted Files Coverage Δ
pycardano/crypto/bip32.py 91.30% <ø> (ø)
pycardano/address.py 77.65% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daehan-koreapool daehan-koreapool marked this pull request as ready for review October 22, 2022 07:06
@daehan-koreapool
Copy link
Contributor Author

Updates

  • Added more enterprise and pointer address tests matching with Emurgo's serialization library
  • Relocated bip32 tests to an appropriate directory

@cffls cffls merged commit f054d47 into Python-Cardano:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants