Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction builder with metadata example #327

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Add transaction builder with metadata example #327

merged 4 commits into from
Mar 5, 2024

Conversation

B3nac
Copy link
Contributor

@B3nac B3nac commented Mar 5, 2024

Hi! I created an example today and thought I'd share. Awesome library, I'm having so much fun with it!

P.S. the discord invite is invalid, please update. Cheers! 🍻

@nielstron
Copy link
Contributor

Thanks for submitting this PR!

Could you add a comment about which CIP this transaction metadata is for? Or alternatively make it match the format of some CIP so users can see how to map between CIP specifications and PyCardano Metadata :)

Also which discord link do you mean? I clicked on the badge in the readme and it was still valid.

@B3nac
Copy link
Contributor Author

B3nac commented Mar 5, 2024

Yeah for sure! I'll work on it at lunch. Turns out Brave shields were blocking the Discord invite 😆.

Copy link
Contributor

@nielstron nielstron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much!

@cffls
Copy link
Collaborator

cffls commented Mar 5, 2024

Thanks for your contribution @B3nac ! There is one minor issue in the format checker. You can reformat the code with make format and verify it with make qa.

@B3nac
Copy link
Contributor Author

B3nac commented Mar 5, 2024

No problem @nielstron @cffls! That should do the trick. 🍻

@cffls cffls merged commit 478f5ef into Python-Cardano:main Mar 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants