Skip to content

Conversation

cffls
Copy link
Collaborator

@cffls cffls commented Sep 27, 2025

Fixes #460

@cffls cffls requested a review from tacmota September 27, 2025 02:31
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.77%. Comparing base (2de335e) to head (f6d9a20).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/crypto/bip32.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   89.76%   89.77%           
=======================================
  Files          33       33           
  Lines        4886     4890    +4     
  Branches      738      740    +2     
=======================================
+ Hits         4386     4390    +4     
  Misses        321      321           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tacmota tacmota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Later we can look into the type check problem.

@cffls cffls merged commit 6b60049 into Python-Cardano:main Sep 27, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for non hardened key derivation using BIP32ED25519PublicKey
2 participants