Skip to content

Fix another issue with attribute lists (with multiple ‘=’ signs) #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2016
Merged

Fix another issue with attribute lists (with multiple ‘=’ signs) #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions markdown/extensions/attr_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,17 @@


def _handle_double_quote(s, t):
k, v = t.split('=')
k, v = t.split('=', 1)
return k, v.strip('"')


def _handle_single_quote(s, t):
k, v = t.split('=')
k, v = t.split('=', 1)
return k, v.strip("'")


def _handle_key_value(s, t):
return t.split('=')
return t.split('=', 1)


def _handle_word(s, t):
Expand Down
1 change: 1 addition & 0 deletions tests/extensions/attr_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,6 @@ <h1>Bad attributes</h1>
<p>No <em>key or value</em></p>
<p><em>Weirdness</em></p>
<p><em>More weirdness</em></p>
<p>This should not cause a <em foo="a=b">crash</em></p>
<p>Attr_lists do not contain <em>newlines</em>{ foo=bar
key=value }</p>
2 changes: 2 additions & 0 deletions tests/extensions/attr_list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,7 @@ No *key or value*{ = }

*More weirdness*{ === }

This should not cause a *crash*{ foo=a=b }

Attr_lists do not contain *newlines*{ foo=bar
key=value }