Support std::unique_ptr

[troopa81]

It's not possible to use std::unique_ptr as arguments. It works as returned value only.

Here is an example unique_ptr.zip

The problem is that even if we write the appropriate MappedType, the generated code that call the method with a std::unique_ptr argument should std::move this one

extern "C" {static PyObject *meth_Test_setObject(PyObject *, PyObject *);}
static PyObject *meth_Test_setObject(PyObject *sipSelf, PyObject *sipArgs)
{
...
    {
        std::unique_ptr<::AnObject>* a0;
        ::Test *sipCpp;

        if (sipParseArgs(&sipParseErr, sipArgs, "BJ3", &sipSelf, sipType_Test, &sipCpp, sipType_std_unique_ptr_0100AnObject, &a0, SIP_NULLPTR))
        {
          // sipCpp->setObject(*a0); // generated code, doesn't work, we need to move
	  sipCpp->setObject(std::move(*a0));

            Py_INCREF(Py_None);
            return Py_None;
        }
    }
...
}

Could it be supported by SIP ?

[nyalldawson]

Ideally the conversion from python -> C++ would also check that the object IS owned by python first, and if not then raise some kind of Python exception (RuntimeError?) stating that it's not possible to call the method with an object which isn't owned by python.

(Otherwise we'll eventually get a double free crash somewhere)

[philthompson10]

Adding a /Movable/ (or similar - /NonCopyable/?) mapped type annotation shouldn't be too much of a problem.

I don't see a problem with ownership so long as /Transfer/ is used properly. It may be possible that mapped type conversion code doesn't currently have enough context to handle transfers of ownership properly in this case.

Can I assume that the common use case is going to be when unique_ptrs are going to be passed and returned by value?

[philthompson10]

I've implemented the /Movable/ mapped type annotation. It also automatically does a /Transfer/ when such a type is passed as an argument so there is no need to remember to do this explicitly. There is a unit test (based on your original test case).

[nyalldawson]

Thanks @philthompson10 , that looks great!!

[troopa81]

Thank you @philthompson10 , I will give it a try soon