Skip to content

Conversation

troopa81
Copy link
Contributor

@troopa81 troopa81 commented Dec 4, 2024

revert part of #50

with #50 True is displayed instead of the deprecation message

(.venv) ➜  test git:(master) ✗ python test.py
/home/julien/myconf/sip-examples/deprecated/test/test.py:9: DeprecationWarning: Test constructor is deprecated: True
  a=Test()
/home/julien/myconf/sip-examples/deprecated/test/test.py:10: DeprecationWarning: Test.printTestDeprecated() is deprecated: True
  a.printTestDeprecated() # this is a comment

The PR proposes to :

  • not update current item deprecated with parent if another more specific message exist on the current item
  • Update current item with parent message and not True when there is no overloaded message defined on current item

Copy link
Contributor

@philthompson10 philthompson10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'd rolled back all the changes to the file just to get PyQt working again.

@philthompson10 philthompson10 merged commit 9a5d888 into Python-SIP:develop Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants