Speed up SIP build by indexing #87
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on speeding up the build of QGIS' Python bindings and during that work, I've found a few places where SIP was needlessly slow.
The largest improvements are in places where SIP was doing some O(n) lookup in a loop. I've managed to speed up most of these by keeping a transparent index of various parts of
Specification
and then simply asking the index instead of looping over all items.Some smaller improvements came from using identity comparison instead of equality and improving the name cache packer.
Together, my not-so-scientific tests on QGIS' bindings show a roughly 5x improvement in
sip-build
runtime (sans compilation).