Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Connect4 game #153

Merged
merged 5 commits into from
Oct 3, 2020
Merged

Connect4 game #153

merged 5 commits into from
Oct 3, 2020

Conversation

SuvamPrasd
Copy link
Contributor

@SuvamPrasd SuvamPrasd commented Oct 2, 2020

Description

This is a connect 4 games developed using a python programming language. For this program, I have used the pygame package and Tkinter package for GUI.

Fixes #125

Replace issue_no in the above line, with the issue related to this PR.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

@@ -0,0 +1,5 @@
Before starting the game make sure to install pygame package into your local system or virtual environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements.txt file must include only this:

numpy==1.19.2
pygame==1.9.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the requirements.txt file as per as you requested.

if board[r][col] == 0:
return r

# def print_board(board):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this commented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented code has been removed from the source code.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://screenrec.com/share/A6OIFtuWSr

  • Please change this behavior, once the column is full, the color still changes, leading to a wrong behaviour!

Please look into the matter!

@AdityaJ7 AdityaJ7 merged commit d6719a3 into Python-World:master Oct 3, 2020
@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 3, 2020

@all-contributors please add @SuvamPrasd for code

@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @SuvamPrasd! 🎉

@tusharnankani
Copy link
Member

Good work! @SuvamPrasd

Expecting more contributions from your end! 👍🏻

@SuvamPrasd
Copy link
Contributor Author

Yeah sure dude 😊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect 4 (C4) game with Python
3 participants