Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Added Upcoming Rocket Launch Schedule | Web Scrapper #204

Merged
merged 9 commits into from
Oct 3, 2020
Merged

Added Upcoming Rocket Launch Schedule | Web Scrapper #204

merged 9 commits into from
Oct 3, 2020

Conversation

rajdeep-ray
Copy link
Contributor

@rajdeep-ray rajdeep-ray commented Oct 2, 2020

Description

This script scrapes the upcoming Rocket Launch Schedule and saves it into a JSON and CSV File

Fixes #181

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • My code follows the style guidelines of this project.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

@@ -0,0 +1,2 @@
bs4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add specific version
use pip freeze

pip freeze list>requirements.txt

Copy link
Member

@chavarera chavarera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also solve py-linter error

@rajdeep-ray rajdeep-ray requested a review from chavarera October 3, 2020 06:24
@AdityaJ7 AdityaJ7 self-requested a review October 3, 2020 06:26
@rajdeep-ray
Copy link
Contributor Author

@chavarera the required changes have been done

@mergify mergify bot merged commit 21e57bb into Python-World:master Oct 3, 2020
@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 3, 2020

@all-contributors please add @rajdeep-ray for code

@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @rajdeep-ray! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming Rocket Launch Schedule | Web Scrapper
3 participants