This repository was archived by the owner on Dec 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 263
Added Upcoming Rocket Launch Schedule | Web Scrapper #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chavarera
suggested changes
Oct 3, 2020
@@ -0,0 +1,2 @@ | |||
bs4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add specific version
use pip freeze
pip freeze list>requirements.txt
chavarera
suggested changes
Oct 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also solve py-linter error
@chavarera the required changes have been done |
chavarera
approved these changes
Oct 3, 2020
AdityaJ7
approved these changes
Oct 3, 2020
@all-contributors please add @rajdeep-ray for code |
I've put up a pull request to add @rajdeep-ray! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This script scrapes the upcoming Rocket Launch Schedule and saves it into a JSON and CSV File
Fixes #181
Type of change
Choosing one or more options from the following as per the nature of your Pull request.
NOTE: These boxes can be checked using
[X]
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation Update
Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.
Update index.md
)README.md
, according to the givenREADME_TEMPLATE.