This repository was archived by the owner on Dec 22, 2023. It is now read-only.
Add Economic Times News article fetcher #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaJ7
suggested changes
Oct 6, 2020
| }) | ||
|
|
||
| out_filename = 'ET_NewsData_{}_{}.json'.format(start_date, end_date) | ||
| output_file = open(out_filename, 'w+') |
There was a problem hiding this comment.
use the with statement to open files
| @@ -0,0 +1,71 @@ | |||
| from bs4 import BeautifulSoup | |||
| from lxml import etree | |||
| `python economictimes_scraper.py 2020-05-15 2020-05-20` | ||
| Output will be saved in file `ET_NewsData_STARTDATE_ENDDATE.json` | ||
|
|
||
|
|
There was a problem hiding this comment.
Add a screenshot of the script in action
AdityaJ7
approved these changes
Oct 26, 2020
|
@allcontributors please add @jaynarw for code |
|
I've put up a pull request to add @jaynarw! 🎉 |
|
Python World does not accept pull requests on this repository anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Economic Times News article fetcher
Type of change
Choosing one or more options from the following as per the nature of your Pull request.
NOTE: These boxes can be checked using
[X]Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation Update
Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.
Update index.md)README.md, according to the givenREADME_TEMPLATE.