This repository was archived by the owner on Dec 22, 2023. It is now read-only.
Scrape algo trading articles from quant finance websites #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
tusharnankani
approved these changes
Oct 5, 2020
AdityaJ7
suggested changes
Oct 5, 2020
| quantopian = get_quantopian_articles() | ||
| quantocracy = get_quantocracy_articles() | ||
| quantstart = get_quantstart_articles() | ||
| file = open('output.txt', 'w') |
There was a problem hiding this comment.
Everything else is cool, just use the 'with' statement to open the file
There was a problem hiding this comment.
okay, doin' it
chavarera
approved these changes
Oct 5, 2020
|
@all-contributors add @shivanshsinghal107 for code |
|
I've put up a pull request to add @shivanshsinghal107! 🎉 |
|
ok @shivanshsinghal107 leave the with keyword thing now, will fix it with deepsource-autofix 👍🏽 |
okay thanks |
|
Thanks, this was my very first issue and contribution to open source🎉 |
|
Congratulations! Expecting more contributions from your end! ^_^ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented scraper to get top algo trading and mathematical finance articles.
Fixes #(373)
Replace
issue_noin the above line, with the issue related to this PR.Type of change
Choosing one or more options from the following as per the nature of your Pull request.
NOTE: These boxes can be checked using
[X]New feature (non-breaking change which adds functionality)
Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.
Update index.md)README.md, according to the givenREADME_TEMPLATE.