Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

fixes issue #230 #444

Merged
merged 8 commits into from
Oct 12, 2020
Merged

fixes issue #230 #444

merged 8 commits into from
Oct 12, 2020

Conversation

KhushiGangopadhyay
Copy link
Contributor

Newsapp based on django framework of python

Fixes #230
Made the Newsapp, couldnt add the feature of bookmarking instead added a new feature of changing colour mode, the app uses api from https://newsapi.org/

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • [X ] I have named my files and folder, according to this project's guidelines.
  • [X ] My code follows the style guidelines of this project.
  • [ X] My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • [X ] I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • [X ] I have included a requirements.txt file (if external libraries are required.)
  • [X ] My changes do not produce any warnings.
  • [X ] I have added a working sample/screenshot of the script.

@KhushiGangopadhyay
Copy link
Contributor Author

@AdityaJ7 Can you please tell me what to do to fix this issue

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 9, 2020

@AdityaJ7 Can you please tell me what to do to fix this issue

Hi, sorry for the delay, I'll check and fix it

@KhushiGangopadhyay
Copy link
Contributor Author

removed all the unwanted libraries but I'm using newsapi.org 's api I dont know why its showing error in the import statement in views file

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 9, 2020

removed all the unwanted libraries but I'm using newsapi.org 's api I dont know why its showing error in the import statement in views file

ok I'll check the issue, please remove the pycache files also

@KhushiGangopadhyay
Copy link
Contributor Author

okay

@KhushiGangopadhyay
Copy link
Contributor Author

Can anyone please help me , I'm a newbie and I really don't know how to solve this error , thank you in advance :)

@Anshul275
Copy link
Member

Anshul275 commented Oct 12, 2020

@KhushiGangopadhyay In "views.py" file in line 2 -> from newsapi import NewsApiClient
NewsApiClent is imported but never used.
So remove that line from your code.

You can also head to the details section across each error to know what's is the error exactly and what to do to solve it.
Happy to Help :)

@AdityaJ7
Copy link
Member

@KhushiGangopadhyay sorry for the dealy @KhushiGangopadhyay I have fixed your issue and now merging it. Thanks for the contribution and for having patience.

Will be looking forward to more contributions from your side

Thanks again,

@AdityaJ7 AdityaJ7 merged commit d3c7f29 into Python-World:master Oct 12, 2020
@AdityaJ7
Copy link
Member

@all-contributors please add @KhushiGangopadhyay for code

@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @KhushiGangopadhyay! 🎉

@KhushiGangopadhyay
Copy link
Contributor Author

@AdityaJ7 @Anshul275 Thank you so much!!!!!! :)

@github-actions
Copy link

Python World does not accept pull requests on this repository anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

News App
3 participants