Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

A Crypto Currency Converter #445

Merged
merged 17 commits into from
Oct 12, 2020
Merged

Conversation

abhinavanand123
Copy link
Contributor

@abhinavanand123 abhinavanand123 commented Oct 7, 2020

A Python Cryptocurrency Convertor

Description

Using this converter one can convert the existing currencies value to cryptocurrencies and can check their value.

Fixes #347

Replace issue_no in the above line, with the issue related to this PR.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • [] I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Using this converter one can convert the existing currencies value to cryptocurrencies and can check their value.
Copy link
Contributor Author

@abhinavanand123 abhinavanand123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the necessary changes suggested by @chavarera .

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 9, 2020

first please place your folder under API directory

@AdityaJ7 AdityaJ7 self-requested a review October 9, 2020 14:03
Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first please place your folder under API directory and you have structured it in the form of a package, please structure it as a script which can take input from the user. You can refer to the existing scripts in the repo

Using this converter one can convert the existing currencies value to cryptocurrencies and can check their value.
@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 9, 2020

@abhinavanand123 you can check this Pull request by @MaheshBharadwaj #463 for reference

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 9, 2020

@abhinavanand123 check the PR that i mentioned above try to make your script like that, you have made it like a package currently

@abhinavanand123
Copy link
Contributor Author

first please place your folder under API directory

@abhinavanand123 check the PR that i mentioned above try to make your script like that, you have made it like a package currently

@AdityaJ7 I have made the suggested changes

@mergify mergify bot merged commit 45f6d7a into Python-World:master Oct 12, 2020
@AdityaJ7
Copy link
Member

@all-contributors please add @abhinavanand123 for code

@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @abhinavanand123! 🎉

@github-actions
Copy link

Python World does not accept pull requests on this repository anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
@mergify mergify bot added the nice-job label Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple cryptocurrency convertor with python
3 participants