Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Conversation

schezfaz
Copy link
Contributor

Description

A python script to convert CHMOD permissions from its symbolic notation to its numerical notation and vice versa.

Fixes #494

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @schezfaz thanks for the contribution, the script works fine I just have two suggestions:

  1. Please uncommit the requirements.txt file as no external library is used here and add a screenshot of the script when executed through the command line. So you will have to make some changes in the Readme file also.

  2. Please remove the extra space from the end of the file and just give one space there, 2 spaces must be given before the functions.

@schezfaz
Copy link
Contributor Author

Hey @AdityaJ7! Apologies for the addition of the requirements.txt haha, force of habit. Please have another look, have incorporated the requested changes!!

@schezfaz schezfaz requested a review from AdityaJ7 October 19, 2020 13:50
@AdityaJ7
Copy link
Member

Hey @AdityaJ7! Apologies for the addition of the requirements.txt haha, force of habit. Please have another look, have incorporated the requested changes!!

No problem, Good job

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Since this is a beginner-friendly repository, could you include what CHMOD is and some brief description about it? Attach references, if required!

@schezfaz
Copy link
Contributor Author

Hi @tusharnankani! Sure, makes sense. Have added a small brief on what CHMOD is and its representation. LMKWYT!

@AdityaJ7 AdityaJ7 merged commit 2b8893f into Python-World:master Oct 21, 2020
Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏻
Great work @schezfaz

@github-actions
Copy link

Python World does not accept pull requests on this repository anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python CHMOD simplifier
3 participants